search

jostroOS / website

JostroOS website
https://jostroOS.github.io/website
Other
4 stars 2 forks source link

CHNAGE IS YES #2

Closed ghost closed 3 years ago

ghost commented 3 years ago

i change the everythin

NoozAbooz commented 3 years ago

I will have a look, BTW @moon1789 can you fix the merge conflict?

F-fengzi commented 3 years ago

we should use a new branch if you want to have a look

NoozAbooz commented 3 years ago

we should use a new branch if you want to have a look

So I've had a look, the website is pretty broken so not sure a full merge would work, but maybe coping some cool elements to a dev branch would work better.

F-fengzi commented 3 years ago

we should use a new branch if you want to have a look

So I've had a look, the website is pretty broken so not sure a full merge would work, but maybe coping some cool elements to a dev branch would work better.

what elements do you think is cool to add?

ghost commented 3 years ago

I will have a look, BTW @moon1789 can you fix the merge conflict?

well might think so

ghost commented 3 years ago

what problems tho

ghost commented 3 years ago

index humm leme check

NoozAbooz commented 3 years ago

we should use a new branch if you want to have a look

So I've had a look, the website is pretty broken so not sure a full merge would work, but maybe coping some cool elements to a dev branch would work better.

what elements do you think is cool to add?

Well this more simplified home page looks good, maybe we could change the buttons currently to be a bit smaller and squeeze the "learn more" button in there to redirect to about.html, and move the join our discord button to the footer or header. image

ghost commented 3 years ago

yea , sounds good

F-fengzi commented 3 years ago

well,

  1. the about page is mostly credits, so a "learn more" button to there is not quite accurate
  2. people can easily navigate by the top bar, which is even optimized for mobile
  3. if you really want to add the feature, the original codebase is easier to update. instead of merging this whole new one which is very disordered
NoozAbooz commented 3 years ago

well,

  1. the about page is mostly credits, so a "learn more" button to there is not quite accurate
  2. people can easily navigate by the top bar, which is even optimized for mobile
  3. if you really want to add the feature, the original codebase is easier to update. instead of merging this whole new one which is very disordered

Yea true, maybe we could just close this and either change the about page to have info about the OS itself, or just put os info below the home page.

F-fengzi commented 3 years ago

let's continue this thread in discord lmao, github is not a messaging app