Pull Request Failure

[peacing]

@josuebrunel Hello! I'm hoping you're at least aware I've forked your repository. More than that, I've made some additions to the code too. I tried to push the changes I made back to my forked repository. I also tried to submit a pull request of my changes to your repository... and I'm not sure I did either of those things correctly. Let me know if there's something I need to do for you to view my changes.

Two more things: 1) Once you let me know you can see my updates, I'm happy to discuss what other functions should be included in the fantasy sports program. Also, I tried running your code in a virtual env and got an error again, which means I wasn't actually able to test any of the code I wrote in this pull request. While I believe most of it should work, there were a few things I wasn't sure of (like the filters in the players functions). Of course once I get your code running, I'll test any code I attempt to add.

Thank you!

[josuebrunel]

@unpairestgood hello pal !!

I'm hoping you're at least aware I've forked your repository

Yes i'm

More than that, I've made some additions to the code too. I tried to push the changes I made back to my forked repository. I also tried to submit a pull request of my changes to your repository... and I'm not sure I did either of those things correctly. Let me know if there's something I need to do for you to view my changes.

I figured out what you did. When you want to contribute to a project :

1. You fork it
2. You make the changes on the forked repository
3. As soon as your changes are made and tested, you can submit a pull request

The only thing you did wrong, was to create your own repository and make the changes there. That is why you can't submit a pull request.

Therefore, the thing to do is to make the changes in the forked repository.

Once you let me know you can see my updates, I'm happy to discuss what other functions should be included in the fantasy sports program

I did see your changes

I wasn't actually able to test any of the code I wrote

Ok i see. Could you try this please :

$ git clone https://github.com/unpairestgood/yahoo-fantasy-sport 
$ cd yahoo-fantasy-sport
$ virtualenv env
$ source env/bin/activate
$ pip install -r dev_requirements.txt
$ ./run_test.sh

It should work ( let me know if i doesn't )

reminder : work on the forked repository not on this one.

Keep me posted, going for some :bicyclist:

[peacing]

Josue, I was following those instructions and everything was running smoothly until the last line wouldn't run. Then I realized it should be ./run_tests.sh (not run_test), yes? I believe I ran the test script successfully, though there does still seem to be an error. Here's what the output looked like:

...

Also thanks for explaining what I was doing wrong with regards to working on the forked repository. I haven't tried yet, but I'm sure I'll get that to work and I'll make more progress today!

Best,

[josuebrunel]

@unpairestgood , I think you have to put a oauth.json file the folder. This file must contain at least your consumer_key and your consumer_secre

[peacing]

I do have the oauth.json file in the folder. I wasn't sure if it should be in the yahoo-fantasy-sport folder or the env folder... and I've now tried both to no success. I'll try starting the process again from scratch, just in case I made an error at some point because I don't have any ideas why it's happening. Just in case it helps you, here's what my yahoo-fantasy-sport folder looks like:

I've been making good progress on adding functions today, though they are getting increasingly more complex when you can access sub-resources and/or include filters, for example. It'd be nice to be able to test these. Anyway, have a good one!

[peacing]

Just want to update, I got the yahoo-fantasy-sport tests to work. It's a little embarrassing, but I think the issue was simply I had an extra comma after my consumer_secret in the oauth file. I'm excited to finally get to test my new code...

[josuebrunel]

ahahah cool. 2 important points though :

1. add some tests about your new features in the tests.py file. I tried to make it clear. Let me know if you need any help.
2. Never ever push your credential file to github or anything alike. Unless it's encrypted, just like the oauth.json.enc

I've seen your changes, good job buddy. Hope all tests go smoothly .

To remove a remote file, run the command below:

$ git rm --cached oauth.json