search

josuebrunel / yahoo-fantasy-sport

Python Yahoo! Fantasy Sports
MIT License
28 stars 9 forks source link

Pull Request #1 #23

Closed peacing closed 9 years ago

peacing commented 9 years ago

Pushing all changes to players, teams, rosters, and transactions in fantasy_sport.py as well as tests to tests.py. Not all functions work, will open individual issues to fix remaining bugs

josuebrunel commented 9 years ago

Hello @unpairestgood , i have checked your pull request a lil bit. I'm gonna merge it within the day. Thanks again for what you do. This is a very good job :+1: . Keep it up buddy. By the way i'm gonna try the fix the test which doesn't pass. Have a good day,

josuebrunel commented 9 years ago

By the way, since you have rights on the project, you should be able to merge your own pull request. So, whenever you feel that everything is fine, don't hesitate to merge your pull requests.

peacing commented 9 years ago

Thanks! I'm still getting comfortable with using git, hopefully it'll become second-nature soon enough. I will also check out Landscape and Coveralls and merge when appropriate.

josuebrunel commented 9 years ago

Don't worry it will, I'm sure of that. You can even create your own accounts on those services if you want, then add your forked repository. Having a github account is enough to subscribe to those kind of services. Hope it helped