Closed peacing closed 9 years ago
Hello Paul.
Was this correct? Should I now close this issue?
Yes it was.
But since i merged your pull request and i might have changed some code (sometimes no need to), the first thing to do, is to update your forked repository. To do so , follow the steps below :
Main page of the forked repository
Switch bases
Create a pull request on your forked repository then merge it
Finally
$ git pull origin master
Since your already have committed beforing pulling, you might have some merge conflict when doing the pull.
If you have trouble with some merge conflict, let me know.
Have a good day
I'm happy to report the merge went relatively smoothly without and conflicts ;)
Oh great, happy to hear that
So I created this issue, then changed to code to fix it and wanted to commit the changes by doing the following:
Was this correct? Should I now close this issue?