get_teams_roster_with_filter

[josuebrunel]

Hi @unpairestgood , I disabled the test get_teams_roster_with_filter, so far i don't know why it isn't working. I will inquire as soon as i get some spare time. All your tests pass, one more good job :+1: buddy
You can check tests build history here. Those tests are run at every new commit push to one of the branches or when someone submit a pull request, just like you did. Hope everything is clear now. Have a good evening buddy

[josuebrunel]

2 others tools i use :

• test coverage coveralls.io
• code inspection landscape.io

It kind of help me improve my python code somehow

[josuebrunel]

@unpairestgood , according to the documentation, i don't think we can combine _team resource_ with _roster sub-resource_, let me know if i'm mistaken. Maybe i just didn't catch u well.

[peacing]

@josuebrunel Under the Team resource section of the documentation, there's the following:

Which shows that you can access Roster as a sub-resource from Team (and then even access the Player resource as a sub-resource to roster. This is I think identical output-wise to starting with the Roster resource and then accessing Player as a sub-resource.

My mindset is if they both work, why not include both.

[josuebrunel]

Yeah you right. Ok, works for me then