search

josuebrunel / yahoo-fantasy-sport

Python Yahoo! Fantasy Sports
MIT License
28 stars 9 forks source link

Automatically update roster #44

Open peacing opened 8 years ago

peacing commented 8 years ago

Pull roster current roster info - complete Pull in projections from db - to do Identify optimal lineup - to do

peacing commented 8 years ago

@josuebrunel will consult you on this soon, but feel free to take a look! Hope to catch up soon, gotta run at the moment. :smile:

josuebrunel commented 8 years ago

@unpairestgood OK. let me know then, i will be happy to help :wink:. Sorry for the very long review. I haven't fixed some issue yet. I will let you know as soon as i'm done.

peacing commented 8 years ago

@josuebrunel Unfortunately, I think I broke the metaclass functionality in roster.py. For example, if I run ./run_tests.sh TestPaulRoster test_roster_fo_realz, which should add and drop a player, I get the following error:

screen shot 2015-08-20 at 5 37 27 pm

I know it's been a while since you looked at this code, so I'll be around to help figure out what's causing the issue. I also appreciate you introducing me to new features of Python to help me learn, though I admit I don't have a full understanding of how the metaclass-ing works. My assumption is the point of the super class is to have the classes beneath it share the same functions, and I realize I kind of defeated the purpose of it by having Roster, Player and, Transaction use all different xml_builder functions.

Have a good one,

josuebrunel commented 8 years ago

@unpairestgood , Hello Paul, don't worry, i will dive into that this weekend, and try to figure out why it doesn't work anymore. I may have an idea though. I will investigate and give direction if needed.

Thanks for the work you're doing.

Have a good day too

josuebrunel commented 8 years ago

I think that, one way of fixing that issue, would be to put the transaction class into his own file. I will try this one, and keep you posted