add global option "useMulti" for configuring bulk actions

josx / ra-data-feathers

A feathers rest client for react-admin

MIT License

157 stars 53 forks source link

add global option "useMulti" for configuring bulk actions #139

Closed loming closed 4 years ago

josx commented 4 years ago

Thanks!

I dont understand very well why we need to have a global var for this (just for knowing it), because depends on the service on the backend. Right now if you setup to service on backend with multi, i think will work. or not?
Also tests are not passing, tests are not prepared for this new global option.

loming commented 4 years ago

Hi Josx,

Because FeathersJS set 'multi' to false by default. And the current code requires me to do manual config for all services I have used in react-admin ( my application have more than 15 services.. ), my FeathersJS client options doesn't looks nice that way :P

josx commented 4 years ago

Ok, you are right on having just one global var for that. Please make tests pass, then i will merge the PR.

loming commented 4 years ago

I have added more test cases to cover the changes, thanks :)