Fix type another props should be not required

josx / ra-data-feathers

A feathers rest client for react-admin

MIT License

157 stars 53 forks source link

Fix type another props should be not required #162

Closed berviantoleo closed 3 years ago

berviantoleo commented 3 years ago

Fix #161

berviantoleo commented 3 years ago

I'm not sure if this will enough, feel free to review this changes.

Updates: Ups, seems a library not support node 10.

Is it okay to upgrade into node 12/14 at the circle ci?

josx commented 3 years ago

Great work!

Comments on it:

It is ok not move on node 12.x
It seems tsd not using /test/types files ( i have changed a prop on test/types/index.test-d.ts to see if i got an error running tsd and nothing is happening)
it seems that it is not checking last param well, Now type let you add any other prop with content, but it is not checking type. Example: resource: { id: 11 } Should check id as string on resource, right?

berviantoleo commented 3 years ago

It seems tsd not using /test/types files ( i have changed a prop on test/types/index.test-d.ts to see if i got an error running tsd and nothing is happening)

How about now? I just change the rules and use expectError for checking.

it seems that it is not checking last param well, Now type let you add any other prop with content, but it is not checking type. Example: resource: { id: 11 } Should check id as string on resource, right?

Right, seems I am misunderstand about checking the resources id props. I've changed it now.

josx commented 3 years ago

Well done!