search

josx / ra-data-feathers

A feathers rest client for react-admin
MIT License
157 stars 53 forks source link

Fixes default storageKey value. #165

Closed olosegres closed 3 years ago

olosegres commented 3 years ago

I was just trying to run the code but it didn't work. After debugging, I discovered that the @feathersjs/authentication-client setup script that I copy/paste from official docs is using a different field name.

auth is used in the docs of @feathersjs/authentication-client, in the library itself default is feathers-jwt, and here is token. it's a complete mess :(

Since new users often run the code by copying examples from the documentation, in order not to create unnecessary obstacles and problems for other new users, I think it will be useful to add this fix.

I also made PR to docs https://github.com/feathersjs/docs/pull/1539

josx commented 3 years ago

It makes sense to change it. Please replace it in README.md

olosegres commented 3 years ago

@josx Replaced

ucokfm commented 2 years ago

Please release new version (2.9.2?) that includes this fix, because new installation will get 2.9.1 but current repo README.md is already show 'feathers-jwt' as default storageKey, will take some time to find out that 2.9.1 is still using 'token' as default. Thank you.

josx commented 2 years ago

Sorry about that, now it is done. 2.9.3