search

josx / ra-data-feathers

A feathers rest client for react-admin
MIT License
157 stars 58 forks source link

Use PATCH instead of PUT #20

Closed wedneyyuri closed 6 years ago

wedneyyuri commented 7 years ago

Discussion started in https://github.com/marmelab/admin-on-rest/issues/256

We are sending all attributes as generally API doesn't handle PATCH but just PUT. https://github.com/marmelab/admin-on-rest/issues/256#issuecomment-274870099

And there are good news, because feathers supports PATCH HTTP method.

My proposal is to change our mapRequest method from service.update(...) to service.patch(...):

wedneyyuri commented 7 years ago

Closing because I think it's a low priority improvement, sorry the noise

josx commented 7 years ago

maybe we can put both update and patch, if you need it or want PR is welcomed ;)