josx / ra-data-feathers

A feathers rest client for react-admin
MIT License
157 stars 53 forks source link

Missing depency 'feathers-client' #28

Closed shaunnez closed 6 years ago

shaunnez commented 7 years ago

Doing the following

npm install -g create-react-app create-react-app test-admin cd test-admin/ yarn add admin-on-rest yarn add aor-feathers-client

I believe i have to do the below? yarn add feathers-client

I then create feathersClient.js and update app.js too look like yours

I then get this issue

addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).

josx commented 7 years ago

Try removing node_modules and make npm install instead using yarn. It works.

The problem is that yarn has not the same behaviour as npm I dont know why.

Maybe a clue:

Here on facebook says that is reloading multiple versions of React. https://facebook.github.io/react/warnings/refs-must-have-owner.html

npm ls react

With yarn:

├─┬ admin-on-rest@1.2.1
│ ├─┬ material-ui@0.17.4
│ │ ├── react@15.5.4  extraneous
│ │ ├─┬ react-addons-transition-group@15.6.0
│ │ │ ├── react@15.5.4  extraneous
│ │ │ └─┬ react-transition-group@1.2.0
│ │ │   └── react@15.5.4  extraneous
│ │ └─┬ react-event-listener@0.4.5
│ │   └── react@15.5.4  extraneous
│ ├─┬ material-ui-chip-input@0.13.6
│ │ └── react@15.5.4  extraneous
│ ├── react@15.5.4
│ ├─┬ react-dropzone@3.13.3
│ │ └── react@15.5.4  extraneous
│ ├─┬ react-redux@5.0.5
│ │ └── react@15.5.4  extraneous
│ ├─┬ react-router@4.1.1
│ │ └── react@15.5.4  extraneous
│ ├─┬ react-router-dom@4.1.1
│ │ └── react@15.5.4  extraneous
│ ├─┬ react-router-redux@5.0.0-alpha.6
│ │ └── react@15.5.4  extraneous
│ ├─┬ react-tap-event-plugin@2.0.1
│ │ └── react@15.5.4  extraneous
│ ├─┬ recompose@0.23.5
│ │ └── react@15.5.4  extraneous
│ └─┬ redux-form@6.6.3
│   └── react@15.5.4  extraneous
└── react@15.6.1

With npm:

├─┬ admin-on-rest@1.2.1
│ └── react@15.5.4
└── react@15.6.1
josx commented 7 years ago

@shaunnez did you find the way to use yarn?

simonschllng commented 6 years ago
warning " > aor-feathers-client@0.9.0" has incorrect peer dependency "admin-on-rest@^1.4.0".
warning " > aor-feathers-client@0.9.0" has unmet peer dependency "debug@^3.0.0".
warning " > aor-feathers-client@0.9.0" has unmet peer dependency "feathers-client@>=1.9.0".
warning " > aor-feathers-client@0.9.0" has unmet peer dependency "jwt-decode@^2.2.0".
warning " > aor-feathers-client@0.9.0" has unmet peer dependency "object-diff@^0.0.4".

Why are all dependencies in peerDependencies?

josx commented 6 years ago

We add them in this way because to use this plugin you already need in you package.json feathers and admin on rest. Maybe debug, jwt-decode and object-diff might be as deps.

Where did you get those warnings?

simonschllng commented 6 years ago

I had an aor protect and installed yarn add aor-feathers-client. This gives the warning.

josx commented 6 years ago

Right now, it seems to be working after the bump to 2.x using react-admin

josx commented 6 years ago

Closing this issue, beacuse no activity