search

josx / ra-data-feathers

A feathers rest client for react-admin
MIT License
157 stars 58 forks source link

Rest client does not correctly handle GET_MANY #5

Closed ryanthegiantlion closed 7 years ago

ryanthegiantlion commented 7 years ago

See:

https://marmelab.com/admin-on-rest/RestClients.html#writing-your-own-rest-client

GET_MANY passes a list of ID's while GET_LIST passes a filter parameter. Currently the GET_MANY handler for AOR Feathers Client is not handling a list of ID's as it is expecting a filter parameter.

josx commented 7 years ago

@Ryanthegiantlion we have to research how feathers client is handling many request? any clue on that?

ryanthegiantlion commented 7 years ago

@josx As it stands the aor-feathers-client drops the id's for the GET_MANY request.

The above fix works for me. If you want to reproduce the error to test this fix use a reference field in a list view. AOR will fire off a GET_MANY for the associations with the id's of the reference fields. (As documented in the link above)