search

jotaijs / jotai-devtools

A powerful toolkit to enhance your development experience with Jotai
https://jotai.org/docs/tools/devtools
MIT License
124 stars 29 forks source link

feat: mantine update #126

Closed speaker-ender closed 5 months ago

speaker-ender commented 6 months ago

updates all mantine packages to v7 as pointed out in this issue

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

arjunvegda commented 6 months ago

Thanks a lot for the PR!

I tested the version locally and the styles are off from the current version. Could you bring it to parity with the current UI designs?

I can take a look at the code once the designs are 1:1 with the current version 🙌

speaker-ender commented 6 months ago

@arjunvegda the latest changes should be more in line with the current version.
If there are specific things that are not 1:1, let me know and I'll try to fix them.

arjunvegda commented 6 months ago

Thanks for taking another look. I appreciate the effort you put in!

I still see a lot of disparity between the old UI and the new one 😟 It's missing the Jotai Mascott icon, dark mode applies globally instead of just the dev tools shell, the icons in the time-travel tab are misaligned, and elements seem to be aligned center, to name a few.

Should we consider something like https://github.com/shadcn-ui/ui ? 🤔

Here is a CSB with a repro - https://codesandbox.io/p/sandbox/amazing-hill-mtyvyy?file=%2Fsrc%2FApp.tsx%3A13%2C7

arjunvegda commented 5 months ago

Closing this PR in favor of https://github.com/jotaijs/jotai-devtools/pull/129

Thanks again for kicking off this migration. Your effort made it much easier to bring this fix to the finish line 🙌