jotaijs / jotai-devtools

A powerful toolkit to enhance your development experience with Jotai
https://jotai.org/docs/tools/devtools
MIT License
134 stars 33 forks source link

Expose InternalDevTools for production builds #165

Closed valeriobelli closed 2 months ago

valeriobelli commented 2 months ago

This PR is a follow-up to the discussion https://github.com/jotaijs/jotai-devtools/discussions/102. It's a proposal that we can discard.

This change will allow developers to include the InternalDevTools component in production builds.

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

arjunvegda commented 2 months ago

Thanks for the PR! Unfortunately, this wouldn't work as Jotai only supports dev methods in non-prod build 😟

Exposing the internal states of your app in the prod build may not be a good idea. I'd encourage testing the user behavior in the QA build rather than relying on the internals of how the app works. Alternatively, if you must expose it, you could ship dev builds to your QA environments.

Let's continue our discussion in this thread https://github.com/jotaijs/jotai-devtools/discussions/102