search

jotaijs / jotai-trpc

MIT License
122 stars 7 forks source link

fix: should be mutate method, instead of mutation #10

Closed dai-shi closed 1 year ago

dai-shi commented 1 year ago

I didn't notice mutate is translated to mutation. (even though, we use subscribe for some reason. 🤷‍♂️ )

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c6fcdd175357111712de2593923fd50357b3a69c:

Sandbox Source
React Configuration
React Typescript Configuration
dai-shi commented 1 year ago

@sachinraja Do you have any idea so that this can be detected as type errors? The problem is almost everything in our library code is any type.

dai-shi commented 1 year ago

Merging this anyway. Would still love to hear any ideas for improvements.

sachinraja commented 1 year ago

hey sorry for the very late response. I opened an issue on tRPC so we can address it: https://github.com/trpc/trpc/issues/3342