jotaylor / SPAMM

Spectral Properties of AGN Modeled through MCMC
BSD 3-Clause Clear License
1 stars 2 forks source link

numpy convolve faster than fftw convolve #16

Open antking opened 6 years ago

antking commented 6 years ago

I did some line profiling today and found that the numpy convolve function is several factors faster than the currently implemented pyfftw covolution function. I have replaced the function in the local balmercontinuumcombined log_conv function but should be performed throughout (aka in host galaxy and Fe template and eventually in spectrum object or utils function)

replacement should be done as followed flux_conv = fftwconvolve_1d(flux_rebin, kernel) to flux_conv = np.convolve(flux_rebin, kernel,mode='same')