search

jotaylor / SPAMM

Spectral Properties of AGN Modeled through MCMC
BSD 3-Clause Clear License
1 stars 2 forks source link

Multiprocessing support #40

Closed oliverdamkjaer closed 10 months ago

oliverdamkjaer commented 10 months ago

Parallel functionality has been added. Only works on 1 machine with X amount of cores as of now. MPI is for the future for X amount of machines with Y amount of cores.

jotaylor commented 10 months ago

Did you mean to actually close this, as opposed to merge?

oliverdamkjaer commented 10 months ago

Hi, I mistakenly created a pull request to the official repo. I forked the repo, worked on my fork, and created a branch for multiprocessing. After committing changes to this branch, I tried merging it with my fork's main branch, but it unexpectedly resulted in a pull request to the original repo.

For the future though, would you still suggest that I work on my fork and make pull requests?

jotaylor commented 10 months ago

Hi, I mistakenly created a pull request to the official repo. I forked the repo, worked on my fork, and created a branch for multiprocessing. After committing changes to this branch, I tried merging it with my fork's main branch, but it unexpectedly resulted in a pull request to the original repo.

For the future though, would you still suggest that I work on my fork and make pull requests?

Gotcha! Either way is fine, it just depends on your preferences. It may be good to merge your fork's main into this repo every so often though, rather than waiting for many updates to pile up. I think it's also more typical to work on a dev branch on a forked repo, then make a PR to the origin repo main branch rather than the forked main branch. But there is no wrong way to do git (or python for that matter).