search

jotego / jt12

FM sound source written in Verilog, fully compatible with YM2612, YM3438 (JT12), YM2203 (JT03) and YM2610 (JT10)
GNU General Public License v3.0
116 stars 18 forks source link

Only update keyon events at the first operator #45

Closed greyrogue closed 4 years ago

greyrogue commented 4 years ago

--Fixes hi hat issue with Streets of Rage.

greyrogue commented 4 years ago

In addition to your comments about entry points, this will break non-6 channel versions, so that needs to be addressed as well.

greyrogue commented 4 years ago

Maybe there are four entry points, but they are only allowed to activate if the first operator will be the first one of the four to come out the drop of the last shift register (gated on correct value of next_op?).

jotego commented 4 years ago

Yes, I think that is what Nuke's code shows. So it is like the original file with your delay for the write; or your file with the original 2 (or 4) CSR instances.

jotego commented 4 years ago

Beautiful change. Thanks!