search

jotego / jt12

FM sound source written in Verilog, fully compatible with YM2612, YM3438 (JT12), YM2203 (JT03) and YM2610 (JT10)
GNU General Public License v3.0
120 stars 22 forks source link

Fix cen generation for ADPCM-A #71

Closed gyurco closed 1 year ago

gyurco commented 1 year ago

Commit d4607e1ec4857c7aab4660162e2da53d02fa3890 broke ADPCM-A

This one fixes it for NeoGeo.

gyurco commented 1 year ago

Other option would be to revert the commit in question. It's debatable (for me at least) if it really enables the use of clock enable inputs (or gating the clock).

jotego commented 1 year ago

I think we should go along with whatever they are using in MiSTer for now.

gyurco commented 1 year ago

That would basically revert https://github.com/jotego/jt12/commit/d4607e1ec4857c7aab4660162e2da53d02fa3890 This one was invented by me as a minimal fix.

gyurco commented 1 year ago

The MiSTer version: https://github.com/MiSTer-devel/NeoGeo_MiSTer/blob/master/rtl/jt12/hdl/jt12_div.v (Same as here before d4607e1)