jotego / jtbin

Binary files for MiSTerFPGA, Pocket and other platforms
https://patreon.com/jotego
249 stars 71 forks source link

MC2P, MC2, NEPTUNO - Options can't exceed 32 - MRA's / Configs being unreachable #285

Closed ducasp closed 2 years ago

ducasp commented 2 years ago

Hi, I've found this issue with JTKICKER and its variants (Yie Ar, Ping Pong, etc), not sure if that spreads to other bins/mras as well

The code for the microcontroller that parses configurations allows up to 32 configurations to be used, so, you have from 0 to 9 and from A to V to use. W, X, Y and Z will render options after 32 and those options will be impossible to set.

As an example, I can't get Yie Ar Kung Fu to run because service mode is being positioned on option 34, since the MRA is starting with BASE 16 (translates to OG), so, Flip Screen (17th bit, so 16 + 17 = 33), Upright Controls (18th bit) and Service Mode (19th bit) options are impossible to set on the OSD and core will get from the microcontroller something that is a value stuck, that can't ever change.

To work properly on MC2P, MC2, NEPTUNO cores that have options beyond the 32nd bit either need to be reworked to start at a different offset or have some options removed and not go over the 32nd bit of configurations.

jotego commented 2 years ago

Hi, thank you for the detailed report. MC2/P and Neptuno cores receive little maintenance as there are apparently no patrons backing them. I don't even test them. Unless a certain number of backers appear I cannot really justify spending time on them. However, this is a small request and I'll see if I can do something about it.

ducasp commented 2 years ago

Sure, no problem, I can test MC2P ones, and NEPTUNO should work fine if MC2P does. I fully understand those having low / no priority, thanks anyway for keeping partial support of it and taking some time to look into that.

jotego commented 2 years ago

I have set the undriven upper 32 bit of the status word in Neptuno to all ones. This should go easier with DIP switches, as the one is normally the off option. The 8-bit konami cores affected were fixed with this in commit 5081917

ducasp commented 2 years ago

Thanks for the fix, worked quite nice for Pingpong and Roadfighter and Kicker, but I did not see an Yie Ar Kung Fu updated build, that would be nice (by the way, Yie Ar Kung Fu had its service mode screen upside down, not sure if that is the expected behavior).

jotego commented 2 years ago

I see the updated build for Yie Ar Kung Fu in the folder, with the other files.

ducasp commented 2 years ago

Jtyiear has been updated on neptuno bins, but not on mc2p bins. Thanks 🙂