Closed jotego closed 1 year ago
I think having all previous binaries in version control is not the best practice, especially in a repository like jtbin, so I like the idea overall.
But it is nice that right now, users can see all binary versions with their dates in a folder, and they are used to that, so they'll probably ask for it if this gets removed without replacement.
Regarding Downloader (update_all doesn't download anything directly, just calls downloader), there is no need to change anything. And the related "con" you mentioned is not a concern since that tool was designed to remove previously installed files since the beginning. What would have to be changed is the JTCORES database scripts here: https://github.com/jotego/jtcores_mister/blob/main/.github/update_jtcores.sh and here: https://github.com/jotego/jtpremium/blob/main/.github/update_jtcores.sh so that they grab the RBF files without dates instead.
-[X] Merged PRs from @theypsilon in jtpremium and jtcores_mister repos -[X] Updated the compilation workflow so files are not timestamped -[X] Removed all dated RBF files from JTBIN in https://github.com/jotego/jtbin/commit/9775f01e64f990d07535e6241f7786743f179422
The MiSTer scheme for version control depends on a date attached to the file name. MiSTer selects the RBF name with the oldest timestamp to load.
Pros
Cons
Proposal
Users would still be able to browse old versions, but either using GitHub or git's natural version browsing instead of simply picking up files in a folder by name.
@theypsilon what do you think?