dd: Music issues in Double Dragon core

jotego / jtcores

FPGA cores compatible with multiple arcade game machines and KiCAD schematics of arcade games. Working on MiSTer FPGA/Analogue Pocket

https://patreon.com/jotego

GNU General Public License v3.0

239 stars 41 forks source link

dd: Music issues in Double Dragon core #132

Closed ghost closed 1 year ago

ghost commented 3 years ago

In the first stage, when a character pops through the bricks wall the music cuts out and then it goes back to normal.
Music from the first boss ("The Entrance of Abobo the Giant" track) doesn't sound right from second ~10 or so.

jotego commented 3 years ago

Thank you. The audio was getting clipped because of too much amplification. This is solved in commit https://github.com/jotego/jtdd/commit/3270eceecf6cfd7d01a3f9637605090ae410dd5e I will release the files soon

ghost commented 3 years ago

The first problem (audio cut) is solved with this update, but problem jotego/jtdd#2 persists: Music from the first boss ("The Entrance of Abobo the Giant" track) doesn't sound right from second ~10 or so.

ghost commented 3 years ago

I made an audio capture. In the seconds 1.4, 3, 8 and 10 of the attached MP3 it's more noticeable how a part of the music gets somewhat muted.

This does not happen in the original board, the audio track from vgmrip sounds fine too so you can compare: https://vgmrips.net/packs/pack/double-dragon-arcade#03-the-entrance-of-abobo-the-giant

jtdd.zip

jotego commented 3 years ago

Hi, I have spent a couple of days on this. Could you please run the updater and try again?

jotego commented 3 years ago

Sorry, don't try anything yet. I have to look at it more.

jotego commented 3 years ago

I think it's the same issue seen here: https://github.com/jotego/jtbin/issues/189

jotego commented 3 years ago

Tech notes: The problem with the 1st level boss sound happened in version 200830 too. So it isn't related to the recent changes to the LFO/noise modules. Disabling PMS, or setting the input fixed, removes the glitches. The sound glitch occurs every 1-2 seconds in the second half of the melody Testing the PG module for phase increment accuracy showed no errors --> It might be a dynamic thing.

jotego commented 2 years ago

Any PMS value different than zero shows the issue
Setting the PM input to
DT1 doesn't matter
Setting MUL=1 makes it more obvious
Setting KS_III input to the EG to 0, sounds clean. KS_III>0 shows the issue

Channel usage

0,3: clip not heard
2: clip clearly heard
others: unused

jotego commented 2 years ago

The fix was not good for Konami's Jackal, so I have reverted it in https://github.com/jotego/jt51/commit/c98c61634a837ed4301c7caff9785691f38d0da3

jotego commented 1 year ago

Fixing the decay rate in https://github.com/jotego/jt51/pull/24 did not change change this issue.

jotego commented 1 year ago

I need a more clear case to study this. The issue is too subtle.