search

jotego / jtcores

FPGA cores compatible with multiple arcade game machines and KiCAD schematics of arcade games. Working on MiSTer FPGA/Analogue Pocket
https://patreon.com/jotego
GNU General Public License v3.0
228 stars 40 forks source link

CPS1 Carrier Air Wing sprite priority bug #157

Closed PhantombrainM closed 2 weeks ago

PhantombrainM commented 4 years ago

Yesterday I played Carrier Air Wing all 9 (or 10?) rounds with Continue dip on.

I noticed when the plane is fueled up (all three rounds or so?) that the pipes are flying through the air and I thought it looks weird.

So I opened Youtube and found the same behaviour but also some YT Vidoes without the problem. I think it's a bug.

Wrong (like on MISTer): https://www.youtube.com/watch?v=ev1rgJm6uWw&t=545s

Seems right: https://www.youtube.com/watch?v=T2ffq0MHzGI&t=306s

Also I lost control during the game at stage 7 or 8 (no control anymore and I died). Then I noticed I need to press start again and from that on I was player two (?) until the end of the game. Strange. I don't know why this happened and if it was a one time issue or not. Maybe I'll play it again tonight.

jotego commented 4 years ago

This was originally issue jotego/jtcps#28 but it is described better here. There is a pic here: https://clips.twitch.tv/IntelligentPiercingCoyoteFloof The problem is that when I looked at the internal video signals, the drawing actually makes sense as it is. So I think I may be missing a piece of the puzzle. MAME gets this right but gets the NEMO letters wrong, which are very obvious too. This will get sorted when I finally receive the EPROMs I've been waiting for.

The second issue you mentioned sounds more like a software problem. Maybe a different version of the game will work ok.

c0d3h4x0r commented 4 years ago

I just noticed the same bug and took a photo of it.

5F7EB667-22C7-4CEC-AD71-F0D26B04F378

jotego commented 3 years ago

Technical notes: Layer use: SCR1 = text SCR2 = big plane SCR3 = clouds OBJ = small plane and hoses Control registers: PRIO0 = 0000 PRIO1 = F7FF PRIO2 = 03FE PRIO3 = FFFF Layer control = 6DA -> 110_1101_1010

PhantombrainM commented 3 years ago

FYI. Tested. CPS 01/31/2021 Carrier Air Wing sprite priority glitch after 2rd Level is still present. But new DMA runs butter smooth now.

asturur commented 3 years ago

Also the capcom arcade museum for consoles do this right. in the 30 June version of the core the bug is still present. https://youtu.be/h2tOP2YdL2M?t=419

jotego commented 2 years ago

Fixed in 0fdcb02. But NEMO letters during the demo now look like in MAME. Maybe there are really supposed to be like that?

asturur commented 2 years ago

Oh wow is cool that is been fixed. What was the issue? Does it affects more than just carrier air wing and nemo?

jotego commented 2 years ago

The commit 0fdcb02 that fixed this issue, broke

asturur commented 2 years ago

gonna have 2 copies of the core 😏

asturur commented 1 year ago

Just to test i tried this game on the latest cps1 compiled core and nothing changed. I heard that there was some DTACK changes in the cpu of the core and i wonder if it could make any difference. it didn't.

asturur commented 4 months ago

I tried the latest cps1 compilation from the github actions, the one with the fix for the dtack and cen, from this run https://github.com/jotego/jtcores/actions/runs/9055203490. The issue still persist. Not that there was mention that it could have been fixed, but i guessed a little test was ok to do.

paulb-nl commented 2 weeks ago

The commit 0fdcb02 that fixed this issue, broke "Three wonders" intro. See jotego/jtcps#131 Final Fight and Varth alignment. See jotego/jtcps#132

I am working on this issue. The jtcps repo is gone so I can't see the things that broke with your previous fix. What potential issues should I look at?

Now my changes fix this hoses issue and the Nemo heads animation is only inside the letters like Mame and 3wonders shows the gun in frame only like the pcb footage.

asturur commented 2 weeks ago

I remember final fight had a stage where there was an elevator and the layers were messed up

jotego commented 2 weeks ago

The commit 0fdcb02 that fixed this issue, broke "Three wonders" intro. See jotego/jtcps#131 Final Fight and Varth alignment. See jotego/jtcps#132

I am working on this issue. The jtcps repo is gone so I can't see the things that broke with your previous fix. What potential issues should I look at?

Now my changes fix this hoses issue and the Nemo heads animation is only inside the letters like Mame and 3wonders shows the gun in frame only like the pcb footage.

I have made the original repo visible again, so the links work now. I will hide it again eventually because it creates confusion now that the source code for all cores is centralized in a single repo.

Thank you very much for looking at this. I am looking forward to your patch.

paulb-nl commented 2 weeks ago

Thanks Jotego. I sent the pull request with my changes.

I did not see any layer alignment issues during my testing.

jotego commented 2 weeks ago

Fixed in #802 thanks to @paulb-nl. It introduces a regression in Nemo's animation, though.