xmen: review items - Githubissues

jotego commented 3 months ago

Feedback from toya

[x] Button 3 (special attack) is missing
[x] OSD option for dip switches/Service mode is missing
[x] Player shadow is covering enemies
[x] Magnetos magnet circle is not "circle". See image
[x] Sentinents mouth has sprite glitch -> maybe related to sprite zero (lime in simpsons)
[x] Into scene has Visual glitch on top of wolverine
[x] Explosions have glitches -> same as #741

Toryalai1 commented 3 months ago

I had a look into what the button names are: Attack Jump Mutant Power

jotego commented 3 months ago

thanks

rp-jt commented 1 month ago

I leave here two more review items for xmen:

[x] Shadows not appearing at the end of the first stage
[x] Priority problems between layers in second stage when platform moving up. Probably same as in #772

rp-jt commented 1 month ago

The priority problem with the shadows between objects can be observed in scene 8:

In this picture, we can see three types of shadows:

Projected by the hero and the enemy next to them (works correctly with no overlap)
Projected by the rocks making the top part of the sentinels transparent
Projected below the sentinels, covering their feet

What's happening here is the following:

At the feet of the sentinel, the projection of the rocks' shadow is drawn first as an independent sprite with only shadow information.
After this, the rocks are drawn with their shadows.
As KEEP_OLD=1 , when the sentinels are drawn, the other shadows cannot be overwritten. Even though there's only shadow information, those directions are blocked in the buffer for those lines. Part of the sentinels' shadows is drawn where is not covered by the former ones, that's the reason why only part of the feet is overdrawn

The proposal in #810 does not work to fix this, since both order and priority are completely reversed, leading to the same result for this.

Maybe it can be solved by allowing the transparent pixels only carrying shadow info to be overwritten

jotego commented 1 month ago

when enemies appear from the bottom, a few lines might be missing. Added scene 11 to check this.

frame_00002

rp-jt commented 4 weeks ago

Commit 3127b5b fixed remaining issues related to shadow priority

Since all the points mentioned above have been solved, I am going to close this issue

jotego / jtcores