search

jotego / jtcores

FPGA cores compatible with multiple arcade game machines and KiCAD schematics of arcade games. Working on MiSTer FPGA/Analogue Pocket
https://patreon.com/jotego
GNU General Public License v3.0
240 stars 41 forks source link

Add display_modes to video.json for ngp/ngpc on the Pocket #804

Closed davewongillies closed 2 months ago

davewongillies commented 2 months ago

Analogue have recently added Neo Geo Pocket display modes to firmware version 2.3. It would be nice to get these display_modes lists added to video.json.

JTNGP video.json

    "display_modes": [
      {
        "id": "0x61"
      },
      {
        "id": "0x10"
      },
      {
        "id": "0x20"
      },
      {
        "id": "0x30"
      },
      {
        "id": "0x40"
      },
      {
        "id": "0xE0"
      },
      {
        "id": "0xE1"
      }
    ]

JTNGPC video.json

    "display_modes": [
      {
        "id": "0x62"
      },
      {
        "id": "0x63"
      },
      {
        "id": "0x10"
      },
      {
        "id": "0x20"
      },
      {
        "id": "0x30"
      },
      {
        "id": "0x40"
      },
      {
        "id": "0xE0"
      },
      {
        "id": "0xE1"
      }
    ]
Toryalai1 commented 2 months ago

Isn't this something that the updaters can handle?

jotego commented 2 months ago

We could leave this to the updaters, but I'm ok to adding these feature. Particularly if other cores could also use some specific modes. Do you have any suggestions of modes to add to arcade cores in general or does it work ok as it is?

jotego commented 2 months ago

I just saw an answer to that question in this other issue.

"display_modes": [
      {
        "id": "0x10"
      },
      {
         "id": "0x20"
      },
      {
         "id": "0x30"
      },
      {
         "id": "0x40"
      },
      {
         "id": "0xE0"
      },
      {
         "id": "0xE1"
      }
    ]
jotego commented 2 months ago

Implemented in b89a709b Files will be published on the next update.