jothepro / doxygen-awesome-css

Custom CSS theme for doxygen html-documentation with lots of customization parameters.
https://jothepro.github.io/doxygen-awesome-css/
MIT License
1.04k stars 118 forks source link

[1.4.0] Fragment line height set to 0 by obsolete class #14

Closed r0ckarong closed 3 years ago

r0ckarong commented 3 years ago

https://github.com/jothepro/doxygen-awesome-css/blob/main/doxygen-awesome.css#L882

The line height is then overruled by setting the individual lines' height with the new variable a few lines further down. Is there a special reason the line height is first set to 0 for the fragment and then the lines are set to something else?

jothepro commented 3 years ago
div.fragment {
    line-height: 0;
}

(L883) sets the line height of the fragment container for fragments that define a span for each line, while

div.fragment .line, pre.fragment {
    line-height: var(--fragment-lineheight);
}

(L893) sets the line height for the separate lines & pre fragments, which are fragments without separate spans for each line. So I don't see anything being overriden here. Am I missing sth?

jothepro commented 3 years ago

EDIT:

Nevermind, I was wrong, L883 seems to be obsolete, at least it can be disabled in the developer tools without consequences. Thank you for the observation!

jothepro commented 3 years ago

I removed the obsolete line-height: 0 override. This will be included in the next release.