search

jothepro / doxygen-awesome-css

Custom CSS theme for doxygen html-documentation with lots of customization parameters.
https://jothepro.github.io/doxygen-awesome-css/
MIT License
1.04k stars 118 forks source link

Invalid XHTML #29

Open dsieger opened 3 years ago

dsieger commented 3 years ago

Hi,

First of all: Thanks for your work, this is indeed awesome. I did something similar for our project documentation, but your solution is much cleaner and more comprehensive. I immediately adopted it, see our user guide for an example. I did some minor changes, mostly to the sidebar, maybe you are interested in some of those.

Anyway, the main issue I had was invalid XHTML markup: If you run your site through the W3C validator you'll notice a couple of issues you might want to fix.

Thanks, Daniel

jothepro commented 3 years ago

Thanks for pointing that out, it seems like I have mixed in some html5 by accident...

Thanks for sending me a link of your documentation, it's always helpful to see what others do with the theme! I like the style of the arrows in the sidebar! It seems like the adjustments that you made don't work for the dark theme, though:

Bildschirmfoto 2021-07-01 um 18 04 14

If you don't want / don't care about dark mode you will be able to disable it in the upcoming release by setting

<html class="light-mode">
dsieger commented 3 years ago

Thanks for spotting, fixed. Only tested dark mode on mobile.

For the arrows I simply override the icon used in navtree.js by adding a snippet to my header.html:

<script type="text/javascript">
  var arrowRight = '&#9655;';
</script>