jothepro / doxygen-awesome-css

Custom CSS theme for doxygen html-documentation with lots of customization parameters.
https://jothepro.github.io/doxygen-awesome-css/
MIT License
981 stars 112 forks source link

Dark Mode toggle broken in Doxygen 1.9.2 #52

Closed jothepro closed 2 years ago

jothepro commented 2 years ago

@dmadison reported in #47: On mobile [...] the dark mode toggle runs off the screen. When testing in Chrome using the device toolbar, the dark mode toggle also disappears after resizing (and reappears on refresh).

jothepro commented 2 years ago

I think that I fixed this issue in https://github.com/jothepro/doxygen-awesome-css/commit/b20573ff48d43d35095758bc7cfeb88d0333c39c

I'll have to do some more testing before I am confident, though. @dmadison can you confirm that this works in your setup?

dmadison commented 2 years ago

Thanks for looking into this. I've just tested with that snippet and the toggle is in its proper place and persists on window resize. Although when resizing down to mobile width on desktop the toggle still drops down below the search bar. My guess is that the width of the vertical scroll bar is not accounted for somewhere.

jothepro commented 2 years ago

Yep, Mac user here... 🙈 Thx, I can reproduce this on Windows! I'm confident that https://github.com/jothepro/doxygen-awesome-css/commit/e5368c4265615d07ad8ef6c104fca0934e8fff57 will fix it. I'm now allocating space for the searchbar dynamically with flexbox, instead of hardcoding the width. :)


Offtopic: Omg, this theme looks absolutely awful on Windows... 😮 I should've tested on Windows more often, there is big junky scrollbars literally everywhere! 🙈 Now I get the point of these proposed changes, I'll seriously have to consider adapting them...

Wtf even is this, why didn't you complain about it? 😆

Bildschirmfoto 2021-10-19 um 15 13 20
dmadison commented 2 years ago

I never noticed before! Big monitor problems I suppose, haha.

jothepro commented 2 years ago

Should be fixed with release 1.6.1. Pls re-open if you are still experiencing problems related to the toggle button...