search

jothepro / doxygen-awesome-css

Custom CSS theme for doxygen html-documentation with lots of customization parameters.
https://jothepro.github.io/doxygen-awesome-css/
MIT License
956 stars 108 forks source link

Disable Dark Mode regression #97

Closed higaski closed 1 year ago

higaski commented 1 year ago

A year ago the "disable dark mode" feature has been added after request #54. On more recent versions of Firefox (107.0) this seems to break when the Website appearance in the settings is set to either dark or, on systems with dark theming, automatic.

Here is a comparison with Chromium 107.0.5304.110 202521204-b3e12652-57f5-461b-bd00-165090fb0562

The "header.html" I'm using is a 1:1 copy of the template, just with the class="light-mode" added.

jothepro commented 1 year ago

Thanks for sharing! I remember once stumbling across the same problem about a week ago, but I cannot reproduce it rn on my Mac with Firefox 107. Neither with doxygen 1.9.4 nor 1.9.5.

Can you share some more details about your setup that may help me to trace down when this is happening? Maybe it's OS dependent?

I will try to reproduce it on Windows and Linux later.

higaski commented 1 year ago

Oh yeah sry of course... that might help.

I'm running KDE Plasma 5.26.3 with a theme called Sweet-Dark, but I would have guessed that setting the appearance in the Firefox settings to "dark" would cause the issue as well? :confused:

jothepro commented 1 year ago

Ok, I could reproduce the problem. Make sure to set HTML_COLORSTYLE = LIGHT in your Doxyfile to avoid colliding CSS variables from Doxygen and doxygen-awesome-css!

Pls let me know if this fixes the broken light mode for you.

I'd like to emphasize though that I do not recommend using this theme with doxygen 1.9.5 as of now because of an fixed but unreleased issue that messes with the scrollbar styling: https://github.com/doxygen/doxygen/issues/9549

higaski commented 1 year ago

Quick as always! Thank you, this fixed the issue.