search

jouissances / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #6

Open franfranfranfran opened 7 years ago

franfranfranfran commented 7 years ago

GRADE: Meets Expectations

SUMMARY: Good start on this project! If you shrink down the h1 header text size a bit, the site itself will be looking great and you did an excellent job keeping your project folder organized. Great work using divs and classes to help structure the content on the page as well.

Behind the scenes in the html, be sure not to leave in any unused or unnecessary lines of code. In your css, always be on the lookout for ways that you can reduce repeated lines of styling and make your code more efficient. Clean, concise code is crucial and only becomes more so as your projects grow in size and complexity.

From here, you’re in a great place to spruce up the page beyond what the spec shows. You could try any number of things. One possibility is to put the item text in each section up next to the image. How might we accomplish this? Check here for more info - https://developer.mozilla.org/en-US/docs/Web/CSS/float?v=example

Keep up the great work!

jouissances commented 7 years ago

Hello! Thank you for the prompt review!

With regards to the h1 header text size, I've just realised — when I changed <h1>Dasmoto...Crafts</h1> to <p>Dasmoto...Crafts</p> in index.html, the text size shrank, even though in my stylesheet.css, the class .title was specified to be 100px, and I did not change this. May I know why this is so? Does this apply to <h2 ... 6> as well? Thank you for pointing this out!

About the unused lines of code, they are from the boilerplate HTML template that I figured I might use in the future, but I'll delete the unnecessary lines accordingly from now on! I've learnt a few more things from others as well, such as organising sections (in both HTML and CSS) with brief description comments. So I'll try to implement that in future projects.

Meanwhile, I'll go read up the link you sent me. Thanks once again!