joukevandermaas / saule

JSON API library for ASP.Net Web API 2.
https://joukevandermaas.github.io/saule
MIT License
76 stars 37 forks source link

Related resources #136

Closed yohanmishkin closed 7 years ago

yohanmishkin commented 7 years ago

Here's a spike on #126. Let me know if you feel like it might be worth iterating on and polishing, but I used JSON API Fetching Includes for reference.

joukevandermaas commented 7 years ago

This looks great so far! I'd very much appreciate more work on this. You'll probably have to rebase this on the latest changes in master.

I'll review in more detail later this week if possible.

yohanmishkin commented 7 years ago

Awesome, trying to rebase now. Some strangeness with the line endings is making it a bit tricky.

bjornharrtell commented 7 years ago

@joukevandermaas why was this closed? I'm currently missing this so if you need help resurrecting it I might be able to.

joukevandermaas commented 7 years ago

@bjornharrtell I don't know why this was closed, but I'd very much appreciate you picking it up again if you have time. Thanks!

bjornharrtell commented 7 years ago

Having a hard time with Git and line ending issues.. I see you had some problems too that #135 aimed to fix but as of yet I have not been able to clone the repo without some files getting autoconverted.

bjornharrtell commented 7 years ago

Removing .gitattributes before making a clone works for me.

yohanmishkin commented 7 years ago

Yeah, I got stuck there too. Thanks for picking up @bjornharrtell !

bjornharrtell commented 7 years ago

Thanks for the implementation @yohanmishkin. :) I hope to have use for it in the coming months.