search

joukevandermaas / vim-ember-hbs

Ember Handlebars/HTMLBars plugin for Vim with indentation support
MIT License
46 stars 12 forks source link

Hyphens in sub-component names aren't highlighted for angle brackets syntax #11

Open xtagon opened 4 years ago

xtagon commented 4 years ago

Hi, just noticed that this happens for templates that use sub-components with hyphens in their name. The following example uses ember-paper to demonstrate:

<PaperForm @onSubmit={{action nextStep}} as |form|>
  <step.body>
    <p>Hello, World!</p>
  </step.body>
  <form.submit-button>
    Next
  </form.submit-button>
</PaperForm>

This syntax is valid, but form.submit-button doesn't highlight the -button part:

Annotation 2020-05-20 094157

joukevandermaas commented 4 years ago

This project is in "maintenance mode", which means I will accept prs that fix bugs but I probably won't make time to fix issues like this myself. In this case I think it would be relatively simple to fix the regex, so if anyone wants to do that, I'd be happy to merge a PR.

Thanks for taking the time to report this, I hope this is not too disappointing.

xtagon commented 4 years ago

Thank you, I completely understand. I might take a shot at a PR later but it's not a big priority, at the end of the day it's just colors :)

xtagon commented 2 years ago

I ended up not following up with this, or needing to. I'll leave the issue open in case someone else wants to accept it, just wanted to give an update since originally I planned a PR.