search

joular / joularjx

JoularJX is a Java-based agent for software power monitoring at the source code level.
https://www.noureddine.org/research/joular/joularjx
GNU General Public License v3.0
71 stars 17 forks source link

Added stack-monitoring-sample-rate to agent properties #34

Closed MagielBruntink closed 11 months ago

MagielBruntink commented 11 months ago

Motivation for this PR: in some use cases it is preferable to have a more accurate JVM stack monitoring than the default 10 ms interval provides. Therefore this PR adds the stack-monitoring-sample-rate property so the sample rate/interval can be set by the user via config.properties. Allowable values are checked to be within [1,1000] range, defaulting to 10 ms when not set.

adelnoureddine commented 11 months ago

Thanks @MagielBruntink, this seems all fine to me but I have to check it through locally so everything is working fine. Could you please base your PR on the develop branch instead?

MagielBruntink commented 11 months ago

@adelnoureddine re-based and re-targetted the PR.

adelnoureddine commented 11 months ago

Thanks, I'll merge your PR.