joular / joularjx

JoularJX is a Java-based agent for software power monitoring at the source code level.
https://www.noureddine.org/research/joular/joularjx
GNU General Public License v3.0
71 stars 17 forks source link

feat: add support for macOS monitoring using powermetrics #44

Closed metacosm closed 10 months ago

adelnoureddine commented 10 months ago

Thanks for this contribution! I just have a quick question on the sampling rate (in the code review), otherwise it's a great addition. I'll have to rely on you on testing as I don't have a mac to test on. Does this only works on Macs with Intel processor or also on recent ARM ones ?

metacosm commented 10 months ago

Thanks for this contribution! I just have a quick question on the sampling rate (in the code review), otherwise it's a great addition. I'll have to rely on you on testing as I don't have a mac to test on. Does this only works on Macs with Intel processor or also on recent ARM ones ?

This should work on both, though I have only tested it on Apple Silicon so far, so this should be considered as experimental as it needs to be more validated.

adelnoureddine commented 10 months ago

Thanks @metacosm. Is powermetrics installed by default on all macs? Otherwise, we should update the readme to reflect that. Otherwise all good for me to merge.