Fix for #54 - Githubissues

joular / joularjx

JoularJX is a Java-based agent for software power monitoring at the source code level.

https://www.noureddine.org/research/joular/joularjx

GNU General Public License v3.0

71 stars 17 forks source link

Fix for #54 #55

Closed alamers closed 7 months ago

alamers commented 7 months ago

added support for intel mac power measurements
fixed potential missed messages when buffer wasn't fully read (reusing the same buffered reader now)
added test cases

adelnoureddine commented 7 months ago

Thanks @alamers for the PR and @metacosm for the review. As soon as you're both happy with the code, I'll merge it. So far so good for me, as long as we support :

Intel Mac
M1/M2 mac with combined line or without

metacosm commented 7 months ago

I'm OK with merging as-is.

adelnoureddine commented 7 months ago

Thanks a lot @alamers and @metacosm. This seems to me quite good for me, and I'll merge your PR.