search

joule-labs / joule-extension

Lightning payments extension for Chrome
MIT License
352 stars 61 forks source link

Trouble building extension #15

Closed brandoncurtis closed 5 years ago

brandoncurtis commented 5 years ago

I've attempted to clone, build, and link webln:

git clone git@github.com:/wbobeirne/webln
cd webln
yarn
yarn link

and then clone and build joule-extension:

git clone git@github.com:/wbobeirne/joule-extension
cd joule-extension
yarn link webln
yarn
yarn run build-dev
yarn run dev

node: v10.13.0 npm: v6.4.1 yarn: v1.12.1

This does not appear to build a manifest file in ./dist, so I'm unable to install the unpacked extension.

Did I skip a step?

wbobeirne commented 5 years ago

That's embarrassing, you're 100% correct. I had hard-coded a couple of the files to dist, but they were obviously .gitignored. I'll get webpack to build them correctly at some point, but in the mean time, I'll go ahead and push up the missing files.

wbobeirne commented 5 years ago

Pushed with 727f5174ddb0ae9550616247873bf5955ee4d3c9, thanks again for letting me know.