joule-labs / joule-extension

Lightning payments extension for Chrome
MIT License
352 stars 61 forks source link

admin.macaroon optional #184

Open robclark56 opened 5 years ago

robclark56 commented 5 years ago

By the way LOVE YOUR WORK!

Description of the Feature or Idea

Seems Joule MUST have both admin.macaroon and readonly.macaroon to operate.

But I would like to see a 'read only' option where Joule CAN see the state of the LND node, but can NOT do things that require the admin.macaroon.

Existing Example(s) of Feature

Kinda like a 'watch only' Bitcoin wallet that can watch a wallet (as it has the public keys), but not spend (as it has no private keys).

Comment

Macaroons 101

With the readonly.macaroon, you can 'see but not touch' the LND node With the admin.macaroon, you can do everything With the invoice.macaroon, you can generate new invoices, and that is about all.

Here is what I would like to see:

wbobeirne commented 5 years ago

Hey, thanks for the writeup and sorry for the delayed response. I definitely see the use of a read-only mode, especially after cool features like #177. However, this looks like it'd be a considerable amount of work to do with a good user experience that would hide, disable, or show messaging around the features that require an admin macaroon.

I'm still interested in the idea though, but I think we'll need the provider-agnostic groundwork from #176 to do this feasibly. But I don't see this getting done until quite a few other node use cases are taken care of.