search

joule-labs / joule-extension

Lightning payments extension for Chrome
MIT License
352 stars 61 forks source link

Eclair node compatibility #60

Open wbobeirne opened 5 years ago

wbobeirne commented 5 years ago

https://github.com/ACINQ/eclair

Looks like it doesn't use Macaroons, so it'll probably require some agnostic auth changes since a lot of assumptions are made around using them.

jamesob commented 5 years ago

This might be non-trivial given that Eclair can't receive payments - you'd have to somehow selectively disable functionality in Joule based on the backend.

jnewbery commented 5 years ago

Eclair can't receive payments

That's just for the Eclair android wallet. The eclair node can receive (see eclair RPC reference here: https://github.com/ACINQ/eclair#json-rpc-api which includes a receive method).

VoR0220 commented 5 years ago

Any updates on this? Currently trying to connect through Eclair and it would appear that the REST URL for Eclair is also incompatible in addition to this macaroon business. Is there a way to provide authentication in the header or is that what the discussion is about?

wbobeirne commented 5 years ago

It goes a lot deeper than just the authentication, the entire Eclair API is completely different than LND. No real updates, I unfortunately haven't had a lot of time to tackle this. Hoping to devote more time to it in the next few weeks though.

fiatjaf commented 5 years ago

Shameless self-promotion: https://github.com/fiatjaf/kwh/

kWh is a webln-compatible browser extension with built-in support for Eclair. Not as pretty as Joule for now, but it works.