jouni-kantola / inline-chunk-manifest-html-webpack-plugin

Extension plugin for html-webpack-plugin to inline webpack's chunk manifest. Default inlines in head tag.
MIT License
80 stars 10 forks source link

Add `inject` option #21

Open chaffeqa opened 6 years ago

chaffeqa commented 6 years ago

Supports:

jouni-kantola commented 6 years ago

Thank you for the PR 🥇

A couple of comments:

  1. The inject option you're referring to as documented is actually for html-webpack-plugin.

After we decide if we should add this option or not, then I'd appreciate tests and docs for it.

  1. Tests fits around here: https://github.com/jouni-kantola/inline-chunk-manifest-html-webpack-plugin/blob/master/test/plugin-inject-manifest-test.js#L4

  2. The last bit that I think is missing is docs for the new configuration property. It probably needs extra clarity in this case, since there already is a similar configuration option for html-webpack-plugin.