search

jouni-kantola / mobtimer

Cross-platform mob timer ⏰
4 stars 0 forks source link

Move break toggle #45

Closed jouni-kantola closed 8 months ago

jouni-kantola commented 1 year ago

The current position of the break toggle next to the timer is to keep settings together.

An idea from @jpsalado92 was to move the break toggle. This discussion started here: https://github.com/jouni-kantola/mobtimer/issues/15#issuecomment-1672788566

To not mix too many things topics into the same issue this specific topic can be moved here.

Screenshots from old issue: break-toggle-under-team break-toggle-over-team

jouni-kantola commented 1 year ago

I'm not 100% convinced that the break toggle should be moved. The container that holds the timer and break toggle is called .cycle-settings. From the suggested changes, I think I prefer option 2, with the break toggle above the team.

jouni-kantola commented 8 months ago

@jpsalado92: In v2.7.0 the breaks toggle is moved to a team options section, in line with your suggestion. Thank you! 🥇 Let me know if you come up with any other improvement ideas.

jpsalado92 commented 8 months ago

It looks quite nice, good job with that Jouni!

I wish my current team did some mob programming to provide more feedback for the tool, but will let you know if I come up with anything.

El lun, 1 abr 2024 a las 23:35, Jouni Kantola @.***>) escribió:

@jpsalado92 https://github.com/jpsalado92: In v2.7.0 https://github.com/jouni-kantola/mobtimer/releases/tag/v2.7.0 the breaks toggle is moved to a team options section, in line with your suggestion. Thank you! 🥇 Let me know if you come up with any other improvement ideas.

— Reply to this email directly, view it on GitHub https://github.com/jouni-kantola/mobtimer/issues/45#issuecomment-2030598898, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGHAEWYBZCBTR3SSLSDX5VLY3HHINAVCNFSM6AAAAAA3LJE47SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGU4TQOBZHA . You are receiving this because you were mentioned.Message ID: @.***>