journalovi / 2024-luong-graphical-models

UNDER REVIEW
https://www.journalovi.org/2024-luong-graphical-models/
MIT License
2 stars 0 forks source link

Initial Editor Checklist #1

Closed jsndyks closed 6 months ago

jsndyks commented 6 months ago
chatchavan commented 6 months ago

JoVI template: https://www.journalovi.org/jovi-template-quarto/

jsndyks commented 6 months ago
chatchavan commented 6 months ago

@vuluongj20

 <p><strong>Under Review:</strong> This paper is <a href="https://www.journalovi.org/under-review.html">under review</a> on the experimental track of the <a href="https://www.journalovi.org/">Journal of Visualization and Interaction</a>. See the <a href="">reviewing process</a>.</p>
chatchavan commented 6 months ago

@jsndyks The TOC is available by clicking the button on the top-right corner of the page. I ticked the corresponding checkbox.

mjskay commented 6 months ago

@chatchavan @jsndyks I am not sure github pages is fully set up here: since this is a compiled site, we'll need a github workflow that runs the yarn commands listed in the README and copies the output folder to the gh-pages branch. The publish.yml workflow we use for idyll papers (listed in the experimental track Google doc) should be able to be adapted for this.

Note to OC: update checklist to include check for workflow on compiled papers (ie anything that is not static html)

mjskay commented 6 months ago

(I can make a publish.yml for this article shortly)

jsndyks commented 6 months ago

Thanks @mjskay - should we make that an issue?

jsndyks commented 6 months ago

Waiting on 👆 "all contents are displayed...", otherwise ...

mjskay commented 6 months ago

Publishing should work now.

Since there are a number of other comments on this chain with different folks' responsibilities, I'd recommend moving them all into separate issues so that discussion is easier to follow.

jsndyks commented 6 months ago

Publishing should work now.

Since there are a number of other comments on this chain with different folks' responsibilities, I'd recommend moving them all into separate issues so that discussion is easier to follow.

OK - so is the intention that the 'parent' issue spawns offspring issues? And if so is there a way of modelling that (so that 'parent' can't be resolved until offspring are fixed?) Or is that too complicated and we keep it flat? (with the risk that parent will be closed before offspring are closed?) 😬

mjskay commented 6 months ago

OK - so is the intention that the 'parent' issue spawns offspring issues?

For the initial editor checklist, I think this is a good idea because the items tend to be a bit heterogeneous, and some need our attention and some need the authors' attention. For issues that are reviews, we didn't need to do this on the gather plots paper but we could always try it.

And if so is there a way of modelling that (so that 'parent' can't be resolved until offspring are fixed?) Or is that too complicated and we keep it flat? (with the risk that parent will be closed before offspring are closed?) 😬

This is all experimental so I guess we figure it out ;). One light mechanism for this is to keep checkboxes with issue numbers like this:

These are rendered nicely, and contribute to the overall progress bar at the top when checked. Usually it's easier if they are then collected into the top comment by editing it so you don't have to scroll through replies to find them all.

chatchavan commented 6 months ago

Adding to Matt's comment: You can add reference to an issue by using the reference button (shown below) or type a hash sign follow by an issue number.

Screenshot 2024-04-26 at 14 40 52
jsndyks commented 6 months ago

https://www.journalovi.org/2024-luong-graphical-models/?retry

Publishing should work now.

Since there are a number of other comments on this chain with different folks' responsibilities, I'd recommend moving them all into separate issues so that discussion is easier to follow.

I still can't see the interactive stuff in here :

I cleared the cache, tried different browsers - is this what you thought you had fixed @mjskay ? Apols if not.

mjskay commented 6 months ago

I cleared the cache, tried different browsers - is this what you thought you had fixed @mjskay ? Apols if not.

Ah sorry, I wasn't clear - I fixed the setup so that if you make changes to the source code of the article and commit them to the main branch, the live version of the paper will automatically be recompiled.

However, the javascript is still broken because the root path used to generate links to assets (like scripts) seems to be hard coded. I think @chatchavan opened an issue for @vuluongj20 to correct this (#4) but perhaps they should be poked more explicitly about it.

mjskay commented 6 months ago

(yeah looking at #4 it could be clearer about whose responsibility it is and that it is necessary for review to proceed)

chatchavan commented 6 months ago

I checked off the following points because they are completed and confirmed by the authors

chatchavan commented 6 months ago

The following point will be handled by Transparent Practices Chair. (It is currently assigned to me to ensure the handing over takes place.)

chatchavan commented 6 months ago

Therefore, this issue can be closed by Jason.

jsndyks commented 6 months ago

@chatchavan and I agree that (at last!) all items are either completed or have a dedicated issue to track them.