Closed jsndyks closed 6 months ago
JoVI template: https://www.journalovi.org/jovi-template-quarto/
@vuluongj20
[x] Fix the path prefix to work with the following URL https://www.journalovi.org/2024-luong-graphical-models/
(or ideally any URL prefix.
[x] Add the following HTML block at the top of the page
<p><strong>Under Review:</strong> This paper is <a href="https://www.journalovi.org/under-review.html">under review</a> on the experimental track of the <a href="https://www.journalovi.org/">Journal of Visualization and Interaction</a>. See the <a href="">reviewing process</a>.</p>
@jsndyks The TOC is available by clicking the button on the top-right corner of the page. I ticked the corresponding checkbox.
@chatchavan @jsndyks I am not sure github pages is fully set up here: since this is a compiled site, we'll need a github workflow that runs the yarn
commands listed in the README and copies the output folder to the gh-pages
branch. The publish.yml workflow we use for idyll papers (listed in the experimental track Google doc) should be able to be adapted for this.
Note to OC: update checklist to include check for workflow on compiled papers (ie anything that is not static html)
(I can make a publish.yml for this article shortly)
Thanks @mjskay - should we make that an issue?
Waiting on 👆 "all contents are displayed...", otherwise ...
Publishing should work now.
Since there are a number of other comments on this chain with different folks' responsibilities, I'd recommend moving them all into separate issues so that discussion is easier to follow.
Publishing should work now.
Since there are a number of other comments on this chain with different folks' responsibilities, I'd recommend moving them all into separate issues so that discussion is easier to follow.
OK - so is the intention that the 'parent' issue spawns offspring issues? And if so is there a way of modelling that (so that 'parent' can't be resolved until offspring are fixed?) Or is that too complicated and we keep it flat? (with the risk that parent will be closed before offspring are closed?) 😬
OK - so is the intention that the 'parent' issue spawns offspring issues?
For the initial editor checklist, I think this is a good idea because the items tend to be a bit heterogeneous, and some need our attention and some need the authors' attention. For issues that are reviews, we didn't need to do this on the gather plots paper but we could always try it.
And if so is there a way of modelling that (so that 'parent' can't be resolved until offspring are fixed?) Or is that too complicated and we keep it flat? (with the risk that parent will be closed before offspring are closed?) 😬
This is all experimental so I guess we figure it out ;). One light mechanism for this is to keep checkboxes with issue numbers like this:
These are rendered nicely, and contribute to the overall progress bar at the top when checked. Usually it's easier if they are then collected into the top comment by editing it so you don't have to scroll through replies to find them all.
Adding to Matt's comment: You can add reference to an issue by using the reference button (shown below) or type a hash sign follow by an issue number.
https://www.journalovi.org/2024-luong-graphical-models/?retry
Publishing should work now.
Since there are a number of other comments on this chain with different folks' responsibilities, I'd recommend moving them all into separate issues so that discussion is easier to follow.
I still can't see the interactive stuff in here :
I cleared the cache, tried different browsers - is this what you thought you had fixed @mjskay ? Apols if not.
I cleared the cache, tried different browsers - is this what you thought you had fixed @mjskay ? Apols if not.
Ah sorry, I wasn't clear - I fixed the setup so that if you make changes to the source code of the article and commit them to the main branch, the live version of the paper will automatically be recompiled.
However, the javascript is still broken because the root path used to generate links to assets (like scripts) seems to be hard coded. I think @chatchavan opened an issue for @vuluongj20 to correct this (#4) but perhaps they should be poked more explicitly about it.
(yeah looking at #4 it could be clearer about whose responsibility it is and that it is necessary for review to proceed)
I checked off the following points because they are completed and confirmed by the authors
If anything in the above list is missing (required paper sections, supplemental materials, etc), create an issue tagging the authors and ask them to add those materials (do this after sending them the intial review email).
All contents are displayed as in the author's original compiled version
The following point will be handled by Transparent Practices Chair. (It is currently assigned to me to ensure the handing over takes place.)
Therefore, this issue can be closed by Jason.
@chatchavan and I agree that (at last!) all items are either completed or have a dedicated issue to track them.
[x] Article uses a format something similar to the template
[x] Includes author information
[x] Includes abstract
[x] Includes the required paper sections
[x] All figures have alt texts that describe the content non-visually
[x] Add a notice infobox at the top that the paper is under review w/ link to github issues above the abstract. In Quarto this looks like:
[x] Set up github pages
actions/*,quarto-dev/*
[x] From the main repo page, click the settings gear icon next to "About" on the right.
[x] Verify the publishing workflow works. On the repo page, go to Actions and click on the "XXX Publish" (XXX = Quarto/Idyll/etc) workflow on the left, then click Run Workflow and run it.
[x] Edit README.md and add the following at the very top:
[x] #3
[x] If anything in the above list is missing (required paper sections, supplemental materials, etc), create an issue tagging the authors and ask them to add those materials (do this after sending them the intial review email).
[x] All contents are displayed as in the author's original compiled version