search

journalovi / journalovi.github.io

The JoVI website in Quarto
https://www.journalovi.org/
Creative Commons Attribution Share Alike 4.0 International
12 stars 2 forks source link

attempt to fix custom github domain overwriting on publish #13

Closed mjskay closed 1 year ago

mjskay commented 1 year ago

Turns out the custom domain resetting every publish is a result of how Github handles pages with custom domains. This is an attempt to fix (see https://github.com/quarto-dev/quarto-cli/discussions/3249). I will merge without review since this doesn't change page content, I just need to debug this stupid domain stuff...

mjskay commented 1 year ago

Nevermind, can't merge without review without changing repo settings. Hopefully my first attempt at fixing this works and we don't need to do a tight debugging loop :).

Can someone (@floe @lonnibesancon @chatchavan) hit approve on this? thanks!

mjskay commented 1 year ago

Thanks @floe! This seems to have fixed it.