journeyapps / zxing-android-embedded

Barcode scanner library for Android, based on the ZXing decoder
https://journeyapps.com/
Apache License 2.0
5.73k stars 1.27k forks source link

A flag for ViewfinderView, to hide the red line, and the yellow points #263

Open kangle1208 opened 7 years ago

kangle1208 commented 7 years ago

Hi rkistner Thank you very much for yours "zxing-android-embedded"

When scanning code, there is a red line, and some yellow points, on the screen

If users don't want to see the red line and yellow points they need to modify the source, and rebuild a jar or aar file and then, import the jar/aar file into their project and use it like this: compile( name: 'zxing-android-embedded-3.4.0', ext: 'aar' )

If add a flag for ViewfinderView.java, and do some change in the "onDraw" method Users just set the flag, and no need to build jar/aar file Just use it like this: compile 'com.journeyapps:zxing-android-embedded:3.4.0'

Just for more simple, is this usefull?

Thank you very much, again!

kangle1208 commented 7 years ago

Oh......, with the custom_barcode_scanner.xml,the problem is fixed But, with a flag, may be more simple, am I right? :)

rkistner commented 7 years ago

Yes, that could be a useful shortcut. Pull requests welcome.

chris8447 commented 6 years ago

Yeah please change it so that it is possible to set it via the Java class.

Great work guys! 😊

AbubakarSiddique commented 8 months ago

Is it implemented?