journeyapps / zxing-android-embedded

Barcode scanner library for Android, based on the ZXing decoder
https://journeyapps.com/
Apache License 2.0
5.68k stars 1.26k forks source link

Update notes on minSdkVersion #666

Closed rkistner closed 2 years ago

rkistner commented 2 years ago

See discussion in #612.

This now documents SDK 19+ as "supported", but requires additional config.

SDK < 19 is documented as unsupported now - I don't have any test devices for that.

zx2c4 commented 2 years ago

Just remove the silly downgrade suggestion, and instead list the proper instructions only for API 19.

rkistner commented 2 years ago

I disagree with that - downgrading the dependency is the simplest, and has the least impact on the build process and the rest of the app. zxing:core 3.3.0 should be perfectly fine for most applications.

It's easy to run into issues with multiDex, which can be tricky to debug if you're not familiar with it (for example forgetting to update the Application class, then getting completely unrelated errors). The instructions are there when you want to go that route.