search

jouve / charts

GNU General Public License v3.0
10 stars 16 forks source link

fix: Mailpit rendering of image pull secrets #56

Closed cameronwaterman closed 1 month ago

cameronwaterman commented 1 month ago

Justification

In it's current state, the mailpit chart fails to render image pull secrets.

Implementation

Add helpers for rendering both globally and locally defined image pull secrets and include that helper in the mailpit deployment.

Testing

  1. Set .values.image.pullSecrets to - testSecret
  2. Deployed the chart to minikube, verified the image pull secret was not set
  3. Implemented this change
  4. Deployed the chart to minikube again, verified the image pull secret was now set

I also verified the same behavior for both multiple values and global values.

cameronwaterman commented 1 month ago

@jouve - It doesn't look like there are any branch policies in place to auto-add owners so mentioning you here for visibility.

jouve commented 1 month ago

thanks !