search

jovanbulck / jsh

A basic UNIX shell implementation in C
GNU General Public License v3.0
30 stars 10 forks source link

Localisation with .po files #36

Open GijsTimmers opened 9 years ago

GijsTimmers commented 9 years ago

Request: implement .po translation files

jovanbulck commented 9 years ago

Ok would be cool indeed. This change will require some effort however: changing the code to call gettext whenever some string is outputed and then also of course translating those strings...

I don't have any expierence with gettext yet, so I'll need some time fist to get familiar with the process. I just had a quick look and it looks all right. From a security point of view, it's of major importance to avoid format string vulnerabilities caused by translating format strings. This can be achieved by marking the format string with xgettext:c-format in the code, I see.