jovandeginste / workout-tracker

A workout tracking web application for personal use (or family, friends), geared towards running and other GPX-based activities
Other
958 stars 30 forks source link

Feature/speed map #156

Closed pixelspark closed 5 months ago

pixelspark commented 5 months ago

This slightly refactors the map code to avoid using globals, and adds a speed layer to the map (which can be toggled).

Only issue appears to be that the layers icon is not included yet.

image

jovandeginste commented 5 months ago

I really like this; however, there seems to be a cosmetic issue for me: when I'm not hovering over the height vs speed selection, it's a white square, which does not give any hints that you could do something with it... Is this different in your setup? Or can we add anything in there when not hovering, to hint that you could do something there?

image

pixelspark commented 5 months ago

I am seeing the same thing (this is what I referred to with "Only issue appears to be that the layers icon is not included yet.".

It appears Leaflet expects an image file somwhere (see your Network tab in the web inspector, it will have a 404 in there I assume). We need to find the icon from Leaflet or create an icon for this ourselves and put it in the right place.

jovandeginste commented 5 months ago

Aha thanks; didn't have much time this morning, will look into it later too, unless you found it before.

pixelspark commented 5 months ago

It wants to load http://localhost:8080/assets/dist/images/layers.png, fixed it by copying all leaflet images to the dist folder in the Makefile.