jovandeginste / workout-tracker

A workout tracking web application for personal use (or family, friends), geared towards running and other GPX-based activities
Other
957 stars 30 forks source link

Cleanup code Structure #280

Open Monirzadeh opened 2 months ago

Monirzadeh commented 2 months ago

Hi @jovandeginste this PR is not finish yet but because i like to get your feedback i send this PR incomplete this PR try to move most of the code base under internal for better organize. it helps for easier development over time (separate file bsaed of functionality)

TODO:

Things should done in other PR:

can you please run test for this PR so i can inform as soon as break CI too

jovandeginste commented 2 months ago

(tests have started)

Monirzadeh commented 2 months ago

@jovandeginste can run CI with every push automaticaly?

jovandeginste commented 2 months ago

Probably if you have merged pr's, because then you become a collaborator...

jovandeginste commented 2 months ago

You can run the tests locally?

jovandeginste commented 2 months ago

I'm wondering what code will not be under "internal"...?

Monirzadeh commented 2 months ago

You can run the tests locally?

Yes but somehow I get extra error in local + ci make things easer when it is ready for merge(maybe I should add more test)

Probably if you have merged pr's, because then you become a collaborator...

OK I will try to send another PR to improve ci and we can merge that so we can have better ci + run ci automatically on this PR