Open Monirzadeh opened 2 months ago
(tests have started)
@jovandeginste can run CI with every push automaticaly?
Probably if you have merged pr's, because then you become a collaborator...
You can run the tests locally?
I'm wondering what code will not be under "internal"...?
You can run the tests locally?
Yes but somehow I get extra error in local + ci make things easer when it is ready for merge(maybe I should add more test)
Probably if you have merged pr's, because then you become a collaborator...
OK I will try to send another PR to improve ci and we can merge that so we can have better ci + run ci automatically on this PR
Hi @jovandeginste this PR is not finish yet but because i like to get your feedback i send this PR incomplete this PR try to move most of the code base under internal for better organize. it helps for easier development over time (separate file bsaed of functionality)
TODO:
internal/views
likeassets
andtranslation
internal/database
database
package/dev-data
instead project rootinternal/core
DockeFile
andMakefile
and be sure work with new pathgofumpt
https://github.com/jovandeginste/workout-tracker/pull/291#issuecomment-2338030194Things should done in other PR:
can you please run test for this PR so i can inform as soon as break CI too