fix: prevent number and units from being wrapped

jovandeginste / workout-tracker

A workout tracking web application for personal use (or family, friends), geared towards running and other GPX-based activities

Other

958 stars 30 forks source link

fix: prevent number and units from being wrapped #31

Closed pixelspark closed 8 months ago

pixelspark commented 8 months ago

This PR prevents statistics with units (such as 1:23 min/km) from being wrapped over two lines. This looks much nicer imo.

Before:

After:

I applied the class whitespace-nowrap to all places I could find, might have missed some though.

jovandeginste commented 8 months ago

Can you check if the views remain okay when resizing the viewport? I do this by switching to "mobile view" in firefox (ctrl+shift+m), and then resizing the viewport there...

pixelspark commented 8 months ago

Looks okay.

pixelspark commented 8 months ago

Also, should add 'font-mono' for all the others, just a sec!

jovandeginste commented 8 months ago

FYI, the test fails because DOCTYPE is now capitalized in views/workouts/workouts_list.html; no idea why :)

jovandeginste commented 8 months ago

ah, and icons for the new workout types

pixelspark commented 8 months ago

OK, fixed the doctype and added font-mono to all places where I also applied whitespace-nowrap.

What is the issue with the new icons? I added them in the previous PR and they appear to work fine for me?

jovandeginste commented 8 months ago

pixelspark commented 8 months ago

Weird, somehow that change didn't make it! (I was very proud to have found the "person-drowning" icon for kayaking :-))