search

jovantanyk / pe

0 stars 0 forks source link

Update Command prohibits updating Case Sensitive Name #4

Open jovantanyk opened 2 months ago

jovantanyk commented 2 months ago

image.png

As specified in the UG, the updated name is case sensitive and unique. This means that n/DAVID LI and n/David Li should be classified as two individual persons based on this criteria. As such, the update command should allow updating the name to DAVID LI. Expected Behaviour: Updated Person Actual Behaviour: The person name provided is invalid UG Documentation:

image.png

nus-se-script commented 2 months ago

Team's Response

When we say that names have to be unique, we mean that each name has to have a unique string of characters regardless of case. We understand that this may not have been communicated well in the UG.

We will update the wording to be clearer in future iterations.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add Command prohibits adding Case Sensitive Name

image.png Command input: add n/Betsy CrowE t/friend d/Takes cancer medication k/Jimmy Crowe e/betSycrowe@example.com a/Blk 614A Jurong West Central 2 #20-124 p/93744321 t/lowPriority Output: This person already exists in the address book Expected Output: New person added According to the UG, Name should be case-sensitive and unique. This means that Betsy CrowE and Betsy Crowe should be identified as two unique people.

image.png

[original: nus-cs2103-AY2324S2/pe-interim#1053] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

When we say that names have to be unique, we mean that each name has to have a unique string of characters regardless of case. We understand that this may not have been communicated well in the UG.

We will update the wording to be clearer in future iterations.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]